#16165: Add binary SFPU divide init function #16250
Merged
+95
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdjogoTT
force-pushed
the
rd/binary_sfpu_div_init
branch
from
42e4ea1 to
2c7e9ad
Compare
eyonland
reviewed
Dec 23, 2024
| ALWI void eltwise_binop_tile_init() { MATH((llk_math_eltwise_binary_sfpu_binop_init<APPROX>())); } | ||
| ALWI void add_binary_tile_init() { MATH((llk_math_eltwise_binary_sfpu_binop_init<APPROX, ADD_BINARY>())); } | ||
|
|
||
| ALWI void sub_binary_tile_init() { MATH((llk_math_eltwise_binary_sfpu_binop_init<APPROX, SUB_BINARY>())); } |
There was a problem hiding this comment.
So each binary op is potentially a different init.
There was a problem hiding this comment.
Can we please give the enum a name, make it an enum class, and use that as the template parameter type instead of int?
There was a problem hiding this comment.
Yes each op needs to be able to have a different init. And ok I have changed this to enum class
rdjogoTT
force-pushed
the
rd/binary_sfpu_div_init
branch
from
2c7e9ad to
8cf1b15
Compare
rdjogoTT
requested review from
yan-zaretskiy,
rtawfik01 and
ttmtrajkovic
as code owners
ttmtrajkovic
approved these changes
Jan 2, 2025
eyonland
approved these changes
Jan 2, 2025
rdjogoTT
force-pushed
the
rd/binary_sfpu_div_init
branch
from
8cf1b15 to
f98f708
Compare
mmanzoorTT
added a commit
to tenstorrent/tt-torch
that referenced
this pull request
Jan 6, 2025
* Tests are working after tt-metal fix. * tenstorrent/tt-metal#16250
mmanzoorTT
added a commit
to tenstorrent/tt-torch
that referenced
this pull request
Jan 6, 2025
* Tests are working after tt-metal fix. * tenstorrent/tt-metal#16250
mmanzoorTT
added a commit
to tenstorrent/tt-torch
that referenced
this pull request
Jan 6, 2025
* Tests are working after tt-metal fix. * tenstorrent/tt-metal#16250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Binary SFPU OP divide requires init call.
Checklist